Repository navigation
fix(sentry): delete built source maps after upload - #705
Merged
Merged
Conversation
The delete glob `**/*.map` skips dot folders, so it never reached `.output/`. Every hidden client source map was deployed and served from `/_nuxt/`, and the server maps stayed in the build output.
Collaborator
Author
|
Agent check (Harlan Agent Kit), run by hand because CI builds without the Sentry token and never deletes maps:
|
Collaborator
Author
|
🤖 Harlan Agent Kit Agent assessment of head bd099fe. The Service Review was stopped for this head because the review engine is down. An independent read-only subagent reviewed the diff. This is not a Service No blocker found (confidence 90/100). Deletion runs in the Nuxt Logged follow-ups, none above 80:
|
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #682. Found while reviewing #683.
❓ Type of change
📚 Description
Production serves every client source map. For example,
https://skilld.dev/_nuxt/v2/50scXVS4.js.mapreturns 200. The Sentry delete glob**/*.mapskips dot folders, so it never matched anything in.output/, and the hidden maps shipped as public assets.The glob now names
.output/**/*.map, which covers the public and server maps the Nitro build writes.